SK-235 Add Readme and Sample for Input formatting #209
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
aadarsh-st
requested review from
Devesh-Skyflow,
skyflow-bharti and
skyflow-shravan
There was a problem hiding this comment.
Pull request overview
This PR adds input formatting functionality to the Skyflow Elements library by introducing comprehensive documentation and a working sample implementation. The changes demonstrate how to format user input for various field types using the format and translation options.
Key changes:
- Added a new sample component demonstrating input formatting for phone numbers, emails, OTPs, and card numbers
- Expanded README documentation to explain
formatandtranslationoptions with detailed examples and a comprehensive table - Integrated the new sample into the main application for easy testing
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| samples/SkyflowElements/src/components/InputFormatting/index.tsx | New sample component showcasing various input formatting patterns including phone numbers, emails, and OTPs |
| samples/SkyflowElements/src/App.tsx | Integration of the InputFormatting sample component into the main application |
| README.md | Comprehensive documentation updates for format and translation options with examples and element type compatibility table |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| table={'table1'} | ||
| classes={classes} | ||
| column={'card_number'} | ||
| label={'Collect Card Number'} |
There was a problem hiding this comment.
The placeholder <SKYFLOW_ID> should be replaced with an actual example value or include a comment explaining that users need to replace this with their actual Skyflow ID from their vault.
| label={'Collect Card Number'} | |
| label={'Collect Card Number'} | |
| // TODO: Replace '<SKYFLOW_ID>' with your actual Skyflow ID from your vault |
samples/SkyflowElements/src/components/InputFormatting/index.tsx
Outdated
Show resolved
Hide resolved
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
aadarsh-st
force-pushed
the
sk-235-readme-and-sample-for-input-formatting
branch
from
d733e20 to
4bcc37e
Compare
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
No description provided.