Fix error causing false-positive redeclaration warnings where use of late static binding constants as function arguments were being detected as static variable declarations on subsequent variable arguments to the function.

Author: illusori

Sniffs/CodeAnalysis/VariableAnalysisSniff.php

@@ -1004,6 +1004,12 @@ protected function checkForStaticDeclaration(
         // Static declarations are a bit more complicated than globals, since they
         // can contain assignments. The assignment is compile-time however so can
         // only be constant values, which makes life manageable.
+        //
+        // Just to complicate matters further, late static binding constants
+        // take the form static::CONSTANT and are invalid within static variable
+        // assignments, but we don't want to accidentally match their use of the
+        // static keyword.
+        //
         // Valid values are:
         //   number         T_MINUS T_LNUMBER T_DNUMBER
         //   string         T_CONSTANT_ENCAPSED_STRING
@@ -1031,6 +1037,16 @@ protected function checkForStaticDeclaration(
             return false;
         }
 
+        // Is it a late static binding static::?
+        // If so, this isn't the static keyword we're looking for, but since
+        // static:: isn't allowed in a compile-time constant, we also know
+        // we can't be part of a static declaration anyway, so there's no
+        // need to look any further.
+        $lateStaticBindingPtr = $phpcsFile->findNext(T_WHITESPACE, $staticPtr + 1, null, true, null, true);
+        if (($lateStaticBindingPtr !== false) && ($tokens[$lateStaticBindingPtr]['code'] === T_DOUBLE_COLON)) {
+            return false;
+        }
+
         // It's a static declaration.
         $this->markVariableDeclaration($varName, 'static', null, $stackPtr, $currScope);
         if ($this->isNextThingAnAssign($phpcsFile, $stackPtr) !== false) {

Tests/CodeAnalysis/VariableAnalysisUnitTest.inc

@@ -426,7 +426,7 @@ function function_with_pass_by_ref_assign_only_arg(&$return_value) {
 }
 
 class ClassWithLateStaticBinding {
-    static function method_with_late_static($param) {
+    static function method_with_late_static_binding($param) {
         static::some_method($param);
         static::some_method($var);
         static::some_method(static::CONSTANT, $param);