Add support for spotting static::$member_var outside class scope.

Author: illusori

README.mkdn

@@ -8,7 +8,7 @@ variable use.
  * Warns on use of undefined variables.
  * Warns if variables are set or declared but never used within that scope.
  * Warns if variables are redeclared within same scope.
- * Warns if self::$static_member is used outside class scope.
+ * Warns if $this, self::$static_member, static::$static_member is used outside class scope.
 
 INSTALLATION
 ------------

Sniffs/CodeAnalysis/VariableAnalysisSniff.php

@@ -875,20 +875,29 @@ protected function checkForStaticMember(
         }
         $classNamePtr   = $stackPtr - 2;
         if (($tokens[$classNamePtr]['code'] !== T_STRING) &&
-            ($tokens[$classNamePtr]['code'] !== T_SELF)) {
+            ($tokens[$classNamePtr]['code'] !== T_SELF) &&
+            ($tokens[$classNamePtr]['code'] !== T_STATIC)) {
             return false;
         }
 
         // Are we refering to self:: outside a class?
         // TODO: not sure this is our business or should be some other sniff.
-        if ($tokens[$classNamePtr]['code'] === T_SELF) {
+        if (($tokens[$classNamePtr]['code'] === T_SELF) ||
+            ($tokens[$classNamePtr]['code'] === T_STATIC)) {
+            if ($tokens[$classNamePtr]['code'] === T_SELF) {
+                $err_class = 'SelfOutsideClass';
+                $err_desc  = 'self::';
+            } else {
+                $err_class = 'StaticOutsideClass';
+                $err_desc  = 'static::';
+            }
             if (!empty($token['conditions'])) {
                 foreach (array_reverse($token['conditions'], true) as $scopePtr => $scopeCode) {
                     //  self within a closure is invalid
                     //  Note: have to fetch code from $tokens, T_CLOSURE isn't set for conditions codes.
                     if ($tokens[$scopePtr]['code'] === T_CLOSURE) {
-                        $phpcsFile->addError("Use of self::%s inside closure.", $stackPtr,
-                            'SelfOutsideClass',
+                        $phpcsFile->addError("Use of {$err_desc}%s inside closure.", $stackPtr,
+                            $err_class,
                             array("\${$varName}"));
                         return true;
                     }
@@ -897,8 +906,8 @@ protected function checkForStaticMember(
                     }
                 }
             }
-            $phpcsFile->addError("Use of self::%s outside class definition.", $stackPtr,
-                'SelfOutsideClass',
+            $phpcsFile->addError("Use of {$err_desc}%s outside class definition.", $stackPtr,
+                $err_class,
                 array("\${$varName}"));
             return true;
         }