Hellraise #86
Hellraise #86
Conversation
Fixed Gradle dependencies problem using old version of gradle Functional version, tests passed successfully
- Migrated build system from **Maven** to **Gradle** - Dependencies updated to the latest compatible versions - Partial fixes applied to unit and integration tests
|
|
vsbogd
left a comment
vsbogd
left a comment
There was a problem hiding this comment.
I see few changes (some of which are massive) in this PR:
- migration to Gradle
- migration to JVM 21
- migration to new libraries versions
- fixing issues (not sure whether they are related to changes above or not)
Good practice is to deliver such changes one by one in separate PRs to be able review and discuss them carefully. When a single PR contains all changes then it is difficult to understand which changes in code are caused by which migration. Also some of migrations are questionable. For instance I don't see what is the reason of migration to Gradle build system.
| <version>${protobuf.version}</version> | ||
| <version>4.31.1</version> |
There was a problem hiding this comment.
This version is shared across few locations Please update properties above instead of updating specific version tags.
2 participants
Changes