Stricter objectFromEntries
#67
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it’s possible that the compiler incorrectly assumes keys are defined https://www.typescriptlang.org/play/?noUncheckedIndexedAccess=true&target=11#code/MYewdgzgLgBCBGArApsKAxATiAtgUTCkwEtkIYBeGAeSVSgDoAzbfQksmAQ3IB4BpZAE8YyAB5RkYACbkACtgAOyTFCGChAGhgEipcuMkzyAJWRdp4ADZCAgpkxchvTOctgbMANobtAVzAAazAQAHcwAF0APiiACgA3Lis-MgAuHXZ9AEpKKJgAbwAoAEgfGGIwHQlHNF5dDggvMD8ceBUI7VcLaxEfYX8gkPDorwAGCIj0vGquWvr9Jpa2zA6YLvdPHwHgsMiorwBGCMKAXwBuGBhCwtBIWC4HdPtHZy8AIls37SOYAB9vN4AIS+MAATNFKN4ImdClZkLAQJCECg0FhcPMyLEHpgsjCAPR4y4APQA-NcbuAICA4QwrCAAOaxEAMWwwADUcAYgNxMAJMFCxCsVhgTC4gv5xCgAAsYAA5LiywpAA
sindresorhus
added a commit
that referenced
this pull request
Aug 15, 2025
sindresorhus
added a commit
that referenced
this pull request
Aug 15, 2025
Owner
|
I agree, it should be stricter. Can you take a look at #68? |
julrichkieffer
pushed a commit
to julrichkieffer/ts-extras
that referenced
this pull request
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
It’s possible that the compiler incorrectly assumes keys are defined.
Feel free to disregard if you do not believe this to be an actual issue. Here’s what this change does to the compiler.
Note that in both of these examples I assumed
noUncheckedIndexedAccessis true, which would make the this kind of bug especially surprising to anyone that enabled that feature…