🔔 added health check alerts #905
Open
+72
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzscisoft
added
enhancement
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
wk9874
requested changes
Jan 9, 2026
|
|
||
| @property | ||
| def memory_available_percent(self) -> float: | ||
| return 100 - typing.cast("float", psutil.virtual_memory().percent) |
Collaborator
There was a problem hiding this comment.
Have you tested that these work on windows?
| name="low_available_virtual_memory", | ||
| metric=f"{RESOURCES_METRIC_PREFIX}/memory.virtual.available.percentage", | ||
| threshold=5, | ||
| aggregation="at least one", |
| retention_period: str | None = None, | ||
| timeout: int | None = 180, | ||
| visibility: typing.Literal["public", "tenant"] | list[str] | None = None, | ||
| terminate_on_low_system_health: bool = True, |
Collaborator
There was a problem hiding this comment.
I would default this to false personally
| aggregation="at least one", | ||
| window=2, | ||
| rule="is below", | ||
| trigger_abort=terminate_on_alert, |
Collaborator
There was a problem hiding this comment.
Could also add an email notification option?
|
|
||
| def to_dict(self) -> dict[str, float]: | ||
| """Create metrics dictionary for sending to a Simvue server.""" | ||
| _metrics: dict[str, float] = { |
Collaborator
There was a problem hiding this comment.
Need to rethink how these things are named, the resources metrics page now looks very confusing:
|
|
||
| attempts: int = 0 | ||
|
|
||
| while run._status == "terminated" and attemps < 5: |
Collaborator
There was a problem hiding this comment.
Typo 'attemps' - this will crash
| import random | ||
| import datetime | ||
| import simvue | ||
|
|
Collaborator
There was a problem hiding this comment.
You need to add unit tests:
- Check the metrics appear automatically
- Check if you add a process that spikes the RAM usage / create a large tempfile, the available RAM / memory metrics change appropriately
- Check the options for the alert (terminate, email if you decide to add that) are added to the alert correctly (ie get the alert definition back once its created, check it matches)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add System Health Alerts
Issue: #904
Python Version(s) Tested: 3.13.5
Operating System(s): Ubuntu 25.10
Documentation PR: Issue on Docs repo.
📝 Summary
Adds functionality to prevent run loss after system health failure.
🔄 Changes
Adds pre-defined alerts which trigger when the system is low on health:
✔️ Checklist