Skip to content

Fix offline mode bugs #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kzscisoft merged 4 commits into from
Oct 22, 2025
Merged

Fix offline mode bugs #889

kzscisoft merged 4 commits into from
Oct 22, 2025

Conversation

@wk9874
Copy link
Collaborator

@wk9874 wk9874 commented Oct 21, 2025 •
edited by kzscisoft
Loading

Fix offline mode bugs

Issue: #885 #886

Python Version(s) Tested: 3.10

Operating System(s): Ubuntu

📝 Summary

  • Fix alert deduplication in offline mode and add test
  • Fix snapshot not passing mode through to SimvueConfiguration

🔍 Diagnosis

Identified with VG using offline mode on a cluster and running into issues

✔️ Checklist

  • Unit and integration tests passing.
  • Pre-commit hooks passing.
  • Quality checks passing.

@wk9874 wk9874 requested a review from kzscisoft October 21, 2025 10:44
kzscisoft
kzscisoft requested changes Oct 21, 2025
View reviewed changes
@kzscisoft kzscisoft added this to the Simvue Python API v2.3 milestone Oct 21, 2025
@kzscisoft kzscisoft self-requested a review October 22, 2025 13:29
@kzscisoft kzscisoft merged commit 1add445 into dev Oct 22, 2025
20 checks passed
@kzscisoft kzscisoft deleted the wk9874/885-offline-fixes branch October 22, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzscisoft kzscisoft kzscisoft approved these changes

Assignees

@kzscisoft kzscisoft

Labels

None yet

Projects

None yet

Milestone

Simvue Python API v2.3

Development

Successfully merging this pull request may close these issues.

3 participants

@wk9874 @kzscisoft