Skip to content

Conversation

@wk9874
Copy link
Collaborator

@wk9874 wk9874 commented Aug 14, 2025

Fix 'cannot commit artifact' error message in sender

Python Version(s) Tested: 3.10

Operating System(s): Ubuntu

📝 Summary

Sender automatically does .commit on any objects read from the cache. This isnt required for artifacts, hence you get this error:

INFO:simvue.FileArtifact:Cannot call method 'commit' on write-once type 'Artifact'

🔄 Changes

Simply add a check into the sender so that commit isnt called if the object class is a subclass of ArtifactBase

✔️ Checklist

  • Unit and integration tests passing.
  • Pre-commit hooks passing.
  • Quality checks passing.

@kzscisoft kzscisoft added this to the Python API v2.2 milestone Aug 14, 2025
@kzscisoft kzscisoft self-assigned this Aug 14, 2025
@kzscisoft kzscisoft added bug Something isn't working in review This issue is resolved in a Pull Request which is being reviewed labels Aug 14, 2025
@kzscisoft kzscisoft merged commit 90349cb into dev Aug 15, 2025
20 checks passed
@kzscisoft kzscisoft deleted the hotfix/cannot_commit_artifact branch August 15, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working in review This issue is resolved in a Pull Request which is being reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants