🧪 Fix and Update Test System to be Compatible with CI #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cisoft/test-fixes
Raises an exception if more than one folder is returned for a specific path
Fixes bug where the method for Folder is not passed kwargs
Fixes wrong ID specified during folder deletion assertion
kzscisoft
force-pushed
the
kzscisoft/test-fixes
branch
from
dbe1ef8 to
e6beb39
Compare
kzscisoft
force-pushed
the
kzscisoft/test-fixes
branch
from
e6beb39 to
aff6a90
Compare
Uses raw metrics names request to determine when emission metrics have sent to the server
Uses the files created by the processes in the test for process abort to determine a pass or fail
In the abort processes test use the point at which stdout file is non-zero to mark test completion.
Addresses issue of hanging tests due to threads still running, this includes the QueuedDispatcher subclass.
Removes number of metrics check, just ensures at least one was sent
Ensures all tests have same setup for Run initialisation, also adds flag for changing retention period
kzscisoft
changed the title
wk9874
reviewed
Jun 25, 2025
| return None | ||
|
|
||
| with contextlib.suppress(StopIteration): | ||
| next(_ids) |
Collaborator
There was a problem hiding this comment.
Confused by this - doesnt this mean itll try to do next(_ids), ignore if there isnt another one, and always raise a RuntimeError?
wk9874
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various patches to the tests to ensure consistency
Also contains bug fixes identified during the investigation.