Support for running build command from a task #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for running the build command as a task. This has a use case for a build pipeline with multiple steps (i.e. also compiling Python scripts to a ts4scripts file).
tasks.json:
{ // See https://go.microsoft.com/fwlink/?LinkId=733558 // for the documentation about the tasks.json format "version": "2.0.0", "tasks": [ { "label": "build package", "command": "${command:s4tk.workspace.build}" }, { "label": "build scripts", "type": "shell", "command": "python ../sims4-mod-development-tools/compile.py" }, { "label": "build", "dependsOn": ["build package", "build scripts"], "problemMatcher": [], "group": { "kind": "build", "isDefault": true } }, { "label": "deploy", "type": "shell", "command": "./deploy.sh" }, { "label": "build and deploy", "dependsOrder": "sequence", "dependsOn": ["build", "deploy"] } ] }Before the changes of this PR, it seems that when the command was run as a task like the task "build package" from the tasks.json above, the extension received some JSON object as first argument which was not a URI. With the added URI check from this PR, the command works in both cases, running from command palette or via a task.