prevent errors in Folder to S4TK Project by sanitizing the filenames #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankkulak
reviewed
Sep 11, 2023
frankkulak
reviewed
Sep 11, 2023
frankkulak
reviewed
Sep 11, 2023
frankkulak
reviewed
Sep 11, 2023
frankkulak
reviewed
Sep 11, 2023
frankkulak
reviewed
Sep 11, 2023
frankkulak
requested changes
Sep 11, 2023
Contributor
frankkulak
left a comment
frankkulak
left a comment
There was a problem hiding this comment.
Thanks for the contribution, I'll definitely include file name sanitizing, that should have been in there from the start. I just want a few structural changes to make it more consistent with how the rest of the codebase is written.
frankkulak
reviewed
Sep 24, 2023
frankkulak
approved these changes
Sep 24, 2023
Contributor
frankkulak
left a comment
frankkulak
left a comment
There was a problem hiding this comment.
Looks good! I'll merge soon and do some testing, not 100% sure when I'll be able to get the next release out though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also name the SimData files according to the convention https://vscode.sims4toolkit.com/#/features/resource-keys