Parse request body and ignore unexpected keys #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clara-campos
force-pushed
the
fix-request-data
branch
from
1073803 to
caf63b5
Compare
jacobpenny
reviewed
Dec 1, 2025
basket/news/utils.py
Outdated
| return newsletter_map | ||
|
|
||
|
|
||
| def get_post_request_body(request: HttpRequest, allowed_keys: list[str]): |
There was a problem hiding this comment.
I like the type hints for the parameters but I'm not sure we should introduce them now and only in this function. Are they used anywhere else?
Author
There was a problem hiding this comment.
Hardly anywhere, I'll take them out
clara-campos
force-pushed
the
fix-request-data
branch
from
8bd5df3 to
f585e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.