-
Notifications
You must be signed in to change notification settings - Fork 1
Provide terminal tab autocompletion #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
54478d1 to
c4456d8
Compare
c4456d8 to
76cb497
Compare
3ee1b81 to
1120f33
Compare
BenjaminLangenakenSF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2e526e6 to
9f713c1
Compare
Thanks @BenjaminLangenakenSF it should be solved now! could you give it another try? 🙂 |
BenjaminLangenakenSF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have that issue? 🤔 @michieldegezelle maybe you could have a look as well?
|
michieldegezelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a couple of tests, and did have the issue that Benji encountered, so all good.
Couple of remarks:
- If I type
silverfin import-reconciliation --handle <TAB>, I get an error:
-> Is this to be expected? The list is probably too long to display, but we might have to avoid the error?
-
Shortened options are not autocompleted, can this easily be added (e.g. -h or -t etc.)?
-
Seems to be for all 'second' options:
-> Wanted to add the firm here, and got the error. Could be that I am just willing to autocomplete too much
Apart from this, all good! 👍
9f713c1 to
b1f254b
Compare
b1f254b to
2b4ea0d
Compare
Michiel has reviewed the changes





Fixes #216
Description
The goal is to provide tab autocompletions for
silverfincommand in the terminal. It should auto complete command names, flag names for that specific command, and template names from the current directory.Testing Instructions
Steps:
silverfin config --set-autocompletionsourceline in your~/.zshrcor~/.bashrcfilesource ~/.zshrc)Some examples:
And always, it should autocomplete when there is only one valid option. Options are display when there are multiple.
Author Checklist
Reviewer Checklist