Skip to content

Conversation

@Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Jan 13, 2026

Fixes #366.

I was hoping there was a more straightforward way to do this through the C# libraries, but I didn't see anything. Let me know if I've just missed it.


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from ddaspit January 13, 2026 20:22
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.61%. Comparing base (bca7ec8) to head (8b28605).

Files with missing lines Patch % Lines
...L.Machine/Corpora/ZipParatextProjectFileHandler.cs 66.66% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   72.60%   72.61%           
=======================================
  Files         423      423           
  Lines       35975    35992   +17     
  Branches     4965     4965           
=======================================
+ Hits        26119    26134   +15     
- Misses       8758     8760    +2     
  Partials     1098     1098           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddaspit partially reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93).


src/SIL.Machine/Corpora/FileParatextProjectFileHandler.cs line 18 at r1 (raw file):

        {
            return Directory
                .EnumerateFiles(_projectDir)

I wonder if the overload of this method that takes a pattern and options would be better. Would Directory.EnumerateFiles(_projectDir, fileName, new EnumerationOptions { MatchCasing = false }).Any() work?

@Enkidu93
Copy link
Collaborator Author

src/SIL.Machine/Corpora/FileParatextProjectFileHandler.cs line 18 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

I wonder if the overload of this method that takes a pattern and options would be better. Would Directory.EnumerateFiles(_projectDir, fileName, new EnumerationOptions { MatchCasing = false }).Any() work?

I tried that and it seemed like that overload does not exist on my machine. Maybe something is wrong with my .NET set-up/version? Does it work on your machine?

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit made 2 comments and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93).


src/SIL.Machine/Corpora/FileParatextProjectFileHandler.cs line 18 at r1 (raw file):

Previously, Enkidu93 (Eli C. Lowry) wrote…

I tried that and it seemed like that overload does not exist on my machine. Maybe something is wrong with my .NET set-up/version? Does it work on your machine?

Oh, never mind. It is only available in .NET Standard 2.1. We are using 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If custom.vrs filename is capitalized ("Custom.vrs"), it is not read

4 participants