Skip to content

Conversation

@aror92
Copy link
Contributor

@aror92 aror92 commented Dec 10, 2025

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

LCM Tests

    16 files  ±0      16 suites  ±0   2m 49s ⏱️ -16s
 2 849 tests +1   2 829 ✅ +1   20 💤 ±0  0 ❌ ±0 
11 344 runs  +4  11 176 ✅ +4  168 💤 ±0  0 ❌ ±0 

Results for commit fa430e8. ± Comparison against base commit e29a84c.

♻️ This comment has been updated with latest results.

@jasonleenaylor
Copy link
Contributor

src/SIL.LCModel/DomainImpl/CmPicture.cs line 389 at r1 (raw file):

					return null;
				
				return m_cache.MakeUserTss(metadata.Creator);

Should we escape this too?

Code quote:

metadata.Creator

Copy link
Contributor Author

@aror92 aror92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @jasonleenaylor)


src/SIL.LCModel/DomainImpl/CmPicture.cs line 389 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

Should we escape this too?

done

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aror92)

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aror92)

@aror92 aror92 merged commit a3b309c into master Dec 10, 2025
5 checks passed
@aror92 aror92 deleted the picture-license branch December 10, 2025 19:39
@aror92 aror92 restored the picture-license branch December 10, 2025 23:57
@aror92 aror92 deleted the picture-license branch December 10, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants