Skip to content

Conversation

@myieye
Copy link
Collaborator

@myieye myieye commented Dec 1, 2025

Resolves #2111

Apparently onlyBuiltDependencies should only be set in the root of the workspace:

The field "pnpm.onlyBuiltDependencies" was found in D:\code\languageforge-lexbox\frontend\https-proxy/package.json. This will not take effect. You should configure "pnpm.onlyBuiltDependencies" at the root of the workspace instead.
 The field "pnpm.onlyBuiltDependencies" was found in D:\code\languageforge-lexbox\frontend\viewer/package.json. This will not take effect. You should configure "pnpm.onlyBuiltDependencies" at the root of the workspace instead.

We currently have it in our root package.json file, so it was perhaps already effective for all our packages.

However, there's no guarantee that we'll copy the root package.json file into e.g. a docker container when we're building the viewer. We will however definitely copy pnpm-workspace.yaml, because we need it for version numbers. So, that file is a better place for onlyBuiltDependencies. I needed to update pnpm in order to move it into pnpm-workspace.yaml.

@github-actions github-actions bot added 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related 📦 Lexbox issues related to any server side code, fw-headless included labels Dec 1, 2025
@myieye myieye changed the title Refactor to populate sort ws earlier Move onlyBuiltDependencies into pnpm-workspace.yaml Dec 1, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 1, 2025

📝 Walkthrough

Walkthrough

PNPM package manager version bumped from 10.12.3 to 10.24.0 across frontend Dockerfiles and all package.json manifests. The onlyBuiltDependencies configuration moved from frontend/package.json to frontend/pnpm-workspace.yaml.

Changes

Cohort / File(s) Summary
Docker Configuration
frontend/Dockerfile, frontend/dev.Dockerfile
PNPM version updated from 10.12.3 to 10.24.0 in corepack activation steps
Package Manager Version
frontend/package.json, frontend/https-proxy/package.json, frontend/viewer/package.json
packageManager field updated from pnpm@10.12.3 to pnpm@10.24.0
Built Dependencies Configuration
frontend/package.json, frontend/pnpm-workspace.yaml
onlyBuiltDependencies block removed from package.json and migrated to pnpm-workspace.yaml with entries: esbuild, protobufjs, sharp, svelte-preprocess

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify PNPM 10.24.0 is compatible with all frontend tooling and dependencies
  • Confirm the onlyBuiltDependencies configuration migration from package.json to pnpm-workspace.yaml is correctly recognized by pnpm v10.24.0
  • Check that all package.json files were consistently updated with the new version

Possibly related PRs

Suggested reviewers

  • hahn-kev

Poem

🐰 Hop-hop, dependencies aligned!
PNPM ten-point-two-four in mind,
From package to workspace they flow,
Built deps migrate, steady and slow.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title is vague and does not clearly describe the main change. 'Refactor to populate sort ws earlier' is unclear and does not accurately reflect the core change of moving onlyBuiltDependencies configuration to pnpm-workspace.yaml and upgrading pnpm. Use a clearer title that describes the main change, such as 'Move pnpm onlyBuiltDependencies config to pnpm-workspace.yaml' or 'Upgrade pnpm and relocate onlyBuiltDependencies to workspace root'.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The description is directly related to the changeset and clearly explains why the changes were made, including warnings about onlyBuiltDependencies placement and the rationale for moving it to pnpm-workspace.yaml.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 2111-add-onlybuiltdependencies-to-all-packagejson-files

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

UI unit Tests

  1 files  ±0   45 suites  ±0   17s ⏱️ -2s
111 tests ±0  111 ✅ ±0  0 💤 ±0  0 ❌ ±0 
160 runs  ±0  160 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 12ab641. ± Comparison against base commit c0957ed.

♻️ This comment has been updated with latest results.

@argos-ci
Copy link

argos-ci bot commented Dec 1, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Dec 1, 2025, 9:10 AM

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

C# Unit Tests

137 tests  ±0   137 ✅ ±0   20s ⏱️ +2s
 21 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 12ab641. ± Comparison against base commit c0957ed.

@myieye myieye merged commit c0ee875 into develop Dec 2, 2025
23 checks passed
@myieye myieye deleted the 2111-add-onlybuiltdependencies-to-all-packagejson-files branch December 2, 2025 18:51
@coderabbitai coderabbitai bot mentioned this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related 📦 Lexbox issues related to any server side code, fw-headless included

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add onlyBuiltDependencies to all package.json files

2 participants