-
-
Notifications
You must be signed in to change notification settings - Fork 5
Move onlyBuiltDependencies into pnpm-workspace.yaml #2113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move onlyBuiltDependencies into pnpm-workspace.yaml #2113
Conversation
📝 WalkthroughWalkthroughPNPM package manager version bumped from 10.12.3 to 10.24.0 across frontend Dockerfiles and all package.json manifests. The onlyBuiltDependencies configuration moved from frontend/package.json to frontend/pnpm-workspace.yaml. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Resolves #2111
Apparently
onlyBuiltDependenciesshould only be set in the root of the workspace:We currently have it in our root package.json file, so it was perhaps already effective for all our packages.
However, there's no guarantee that we'll copy the root package.json file into e.g. a docker container when we're building the viewer. We will however definitely copy
pnpm-workspace.yaml, because we need it for version numbers. So, that file is a better place foronlyBuiltDependencies. I needed to update pnpm in order to move it intopnpm-workspace.yaml.