refactor: remove service_name
#8606
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
macladson
reviewed
Dec 22, 2025
Member
macladson
left a comment
macladson
left a comment
There was a problem hiding this comment.
Hey @akronim26, thanks for the PR! Can you do a cargo fmt --all so we can get this passing CI?
chong-he
added
waiting-on-author
jxs
reviewed
Dec 22, 2025
jxs
reviewed
Dec 22, 2025
ackintosh
reviewed
Dec 23, 2025
ackintosh
reviewed
Dec 23, 2025
ackintosh
added
ready-for-review
jxs
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Which issue # does this PR address?
#8586
Proposed Changes
Please list or describe the changes introduced by this PR.
Remove
service_namefromTaskExecutorAdditional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.