Add Short Code Endpoints #780
Open
+518
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cassieemb
requested review from
Devon-White,
Manny-r31,
briankwest,
hey-august and
niravcodes
as code owners
✅ Deploy Preview for signalwire-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
yarn run v1.22.22 OpenAPI Specification AnalysisChanges are compared to the
Done in 147.78s. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REST API Update Pull Request
Related Issue
If there's an issue available, link it here: Issue #17328
Description
We have an endpoint under
relay/restthat lists short codes in the same way that the/phone_numbersendpoint does. However, all three of the supported actions (index, show, update) are currently undocumented. This PR adds the three endpoints, request params, and response bodies.Type of Change
Motivation and Context
I noticed this was missing, and verified it was working as intended. Since it's working and there is no reason for it to be hidden, we should expose it to customers to allow them programmatic control.
Checklist:
team/developer-experiencelabel in the PR.Notes
This worked for me in a SWAGGER tool, but I couldn't get it to show on the website build locally - not sure if I'm missing a step for that part, so I thought I'd push it to see if it built correctly here.It does look correct to me on the preview now!