feat: update GenericModal with new image and link #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added new image for the Developer Basecamp 13 event. * Updated the link in GenericModal to direct to the registration page. * Enhanced the modal's button styles for better user interaction.
shramee
requested changes
Jul 22, 2025
Owner
shramee
left a comment
shramee
left a comment
There was a problem hiding this comment.
Looks good! Just minor suggestions.
| }} | ||
| > | ||
| <a href={link} style={{ display: 'block' }}> | ||
| <a href={link} onClick={(e) => { e.preventDefault(); openInNewTab(link); }} style={{ display: 'block' }}> |
Owner
There was a problem hiding this comment.
We can use target="_blank" here.
| width: "100%", | ||
| height: "100%", | ||
| display: "block", | ||
| cursor: "pointer", |
Owner
There was a problem hiding this comment.
This shouldn't be necessary because the image is in a anchor tags...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-07-21.at.10.54.04.PM.mp4