Skip to content

Commit 9836ea4

Browse files
justin808claude
andcommitted
Trigger generator tests when TypeScript files change
Fixes #2205 When TypeScript files in packages/react-on-rails/ change, the CI change detector now triggers generator tests. This is important because generator tests do a full build, which catches TypeScript compilation errors that might otherwise slip through until npm publish time. The issue arose when PR #2125 changed TypeScript types but the resulting compilation error wasn't caught until the release script ran. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent d67c1aa commit 9836ea4

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

script/ci-changes-detector

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,9 @@ if [ "$SPEC_DUMMY_CHANGED" = true ] || [ "$RUBY_CORE_CHANGED" = true ] || [ "$JS
267267
RUN_DUMMY_TESTS=true
268268
fi
269269

270-
if [ "$GENERATORS_CHANGED" = true ]; then
270+
# JS changes trigger generator tests because generators do a full build
271+
# which catches TypeScript compilation errors (see issue #2205)
272+
if [ "$GENERATORS_CHANGED" = true ] || [ "$JS_CHANGED" = true ]; then
271273
RUN_GENERATORS=true
272274
fi
273275

0 commit comments

Comments
 (0)