Fix broken pnpm lock file for dummy apps (#2201)

### Summary

Spec dummy apps (core and pro dummy apps) didn't set up well when we
migrated to pnpm. `react_on_rails/spec/dummy` and
`react_on_rails_pro/spec/dummy` apps were not part of the monorepo
packages at `<root>/pnpm-workspace.yaml`. This configuration made some
dependencies of dummy apps not installed. Also, it installed different
versions of `react`, which caused a problem with the `react-redux`
package.

Also, we currently use yalc to make dummy apps use the packages. So, I
added `pnpm-workspace.yaml` file to both dummy apps, so each of them
have its own `pnpm-lock.yaml` file and fix all problems. In the future,
if we add the dummy apps to the workspace, we can get rid of the yalc
and make the dummy apps use packages directly.

Seems that claude discovered that problem when it migrated to `pnpm`,
but it made a work around at CI to make it pass. It used the
`--ignore-workspace` argument while installing the dummy apps packages.

Author: AbanoubGhadban

.github/workflows/integration-tests.yml

@@ -153,9 +153,8 @@ jobs:
         # Use --link to maintain the link: protocol that matches pnpm-lock.yaml
         run: cd react_on_rails/spec/dummy && yalc add --link react-on-rails
       - name: Install Node modules with pnpm for dummy app
-        # --ignore-workspace prevents pnpm from treating this as part of the parent workspace
         # minimum config changes package.json (shakapacker version), so can't use frozen lockfile
-        run: cd react_on_rails/spec/dummy && pnpm install --ignore-workspace ${{ matrix.dependency-level == 'minimum' && '--no-frozen-lockfile' || '' }}
+        run: cd react_on_rails/spec/dummy && pnpm install ${{ matrix.dependency-level == 'minimum' && '--no-frozen-lockfile' || '--frozen-lockfile' }}
       - name: Save dummy app ruby gems to cache
         uses: actions/cache@v4
         with:
@@ -260,9 +259,8 @@ jobs:
         # Use --link to maintain the link: protocol that matches pnpm-lock.yaml
         run: cd react_on_rails/spec/dummy && yalc add --link react-on-rails
       - name: Install Node modules with pnpm for dummy app
-        # --ignore-workspace prevents pnpm from treating this as part of the parent workspace
         # minimum config changes package.json (shakapacker version), so can't use frozen lockfile
-        run: cd react_on_rails/spec/dummy && pnpm install --ignore-workspace ${{ matrix.dependency-level == 'minimum' && '--no-frozen-lockfile' || '' }}
+        run: cd react_on_rails/spec/dummy && pnpm install ${{ matrix.dependency-level == 'minimum' && '--no-frozen-lockfile' || '--frozen-lockfile' }}
       - name: Dummy JS tests
         run: |
           cd react_on_rails/spec/dummy

.github/workflows/lint-js-and-ruby.yml

@@ -135,9 +135,7 @@ jobs:
         # Use --link to maintain the link: protocol that matches pnpm-lock.yaml
         run: cd react_on_rails/spec/dummy && yalc add --link react-on-rails
       - name: Install Node modules with pnpm for dummy app
-        # --ignore-workspace prevents pnpm from treating this as part of the parent workspace
-        # The dummy app has its own dependencies and uses yalc links
-        run: cd react_on_rails/spec/dummy && pnpm install --ignore-workspace
+        run: cd react_on_rails/spec/dummy && pnpm install
 
       - name: Install Ruby Gems for package
         run: cd react_on_rails && bundle check --path=vendor/bundle || bundle _2.5.9_ install --path=vendor/bundle --jobs=4 --retry=3

.github/workflows/playwright.yml

@@ -76,10 +76,9 @@ jobs:
 
       - name: Install dummy app dependencies
         working-directory: react_on_rails/spec/dummy
-        # --ignore-workspace prevents pnpm from treating this as part of the parent workspace
         run: |
           bundle install
-          pnpm install --ignore-workspace
+          pnpm install
 
       - name: Install Playwright browsers
         working-directory: react_on_rails/spec/dummy

.github/workflows/precompile-check.yml

@@ -113,11 +113,9 @@ jobs:
       - name: yalc publish for react-on-rails
         run: cd packages/react-on-rails && yalc publish
       - name: yalc add react-on-rails
-        run: cd react_on_rails/spec/dummy && yalc add react-on-rails
+        run: cd react_on_rails/spec/dummy && yalc add --link react-on-rails
       - name: Install Node modules with pnpm for dummy app
-        # --ignore-workspace prevents pnpm from treating this as part of the parent workspace
-        # The dummy app doesn't have a pnpm-lock.yaml
-        run: cd react_on_rails/spec/dummy && pnpm install --ignore-workspace
+        run: cd react_on_rails/spec/dummy && pnpm install
       - name: Save dummy app ruby gems to cache
         uses: actions/cache@v4
         with:

.github/workflows/pro-integration-tests.yml

@@ -136,9 +136,7 @@ jobs:
           pnpm install --frozen-lockfile
 
       - name: Install Node modules with pnpm for Pro dummy app
-        # --ignore-workspace prevents pnpm from treating this as part of the parent workspace
-        # The Pro dummy app has its own dependencies and uses yalc links
-        run: cd spec/dummy && pnpm install --ignore-workspace
+        run: cd spec/dummy && pnpm install
 
       - name: Install Ruby Gems for Pro dummy app
         run: |
@@ -266,9 +264,7 @@ jobs:
           pnpm install --frozen-lockfile
 
       - name: Install Node modules with pnpm for Pro dummy app
-        # --ignore-workspace prevents pnpm from treating this as part of the parent workspace
-        # The Pro dummy app has its own dependencies and uses yalc links
-        run: cd spec/dummy && pnpm install --ignore-workspace
+        run: cd spec/dummy && pnpm install
 
       - name: Ensure minimum required Chrome version
         run: |
@@ -468,9 +464,7 @@ jobs:
           pnpm install --frozen-lockfile
 
       - name: Install Node modules with pnpm for Pro dummy app
-        # --ignore-workspace prevents pnpm from treating this as part of the parent workspace
-        # The Pro dummy app has its own dependencies and uses yalc links
-        run: cd spec/dummy && pnpm install --ignore-workspace
+        run: cd spec/dummy && pnpm install
 
       - name: Ensure minimum required Chrome version
         run: |

.github/workflows/pro-lint.yml

@@ -154,12 +154,10 @@ jobs:
           bundle _2.5.4_ check || bundle _2.5.4_ install --jobs=4 --retry=3
 
       - name: Install Node modules with pnpm for Pro dummy app
-        # --ignore-workspace prevents pnpm from treating this as part of the parent workspace
-        run: cd spec/dummy && pnpm install --ignore-workspace
+        run: cd spec/dummy && pnpm install
 
       - name: Install Node modules with pnpm for ExecJS dummy app
-        # --ignore-workspace prevents pnpm from treating this as part of the parent workspace
-        run: cd spec/execjs-compatible-dummy && pnpm install --ignore-workspace
+        run: cd spec/execjs-compatible-dummy && pnpm install
 
       - name: Generate file-system based entrypoints
         run: cd spec/dummy && bundle exec rake react_on_rails:generate_packs

.github/workflows/pro-test-package-and-gem.yml

@@ -136,8 +136,7 @@ jobs:
           pnpm install --frozen-lockfile
 
       - name: Install Node modules with pnpm for Pro dummy app
-        # --ignore-workspace prevents pnpm from treating this as part of the parent workspace
-        run: cd spec/dummy && pnpm install --ignore-workspace
+        run: cd spec/dummy && pnpm install
 
       - name: Install Ruby Gems for Pro dummy app
         run: |