Skip to content

Don't throw errors inside meshlab #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Astralcircle wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Don't throw errors inside meshlab #70

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4e7d98
Don't throw errors inside meshlab
Astralcircle Nov 13, 2025
04bd73f
Less diff
Astralcircle Nov 13, 2025
9076390
Do it another way
Astralcircle Nov 14, 2025
ea10445
Less diff
Astralcircle Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lua/prop2mesh/cl_meshlab.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ local coroutine_yield = coroutine.yield
local a90 = Angle(0, -90, 0)
local YIELD_THRESHOLD = 30

local devcvar = GetConVar("developer")
local cvar = CreateClientConVar("prop2mesh_render_disable_obj", 0, true, false)
local disable_obj = cvar:GetBool()

Expand Down Expand Up @@ -865,7 +866,10 @@ local function getVertsFromOBJ(custom, partnext, meshtex, meshbump, vmins, vmaxs
local smooth = partnext.vsmooth
local parseErr, errChar, errLine = tryParseObj(modelobj, vmesh, vlook, vmins, vmaxs, pos, ang, scale, invert, meshtex)
if parseErr then
ErrorNoHalt("Prop2Mesh getVertsFromOBJ failure at line " .. errLine .. ", char " .. errChar .. ": " .. tostring(parseErr) .. "\n")
if devcvar:GetBool() then
ErrorNoHalt("Prop2Mesh getVertsFromOBJ failure at line " .. errLine .. ", char " .. errChar .. ": " .. tostring(parseErr) .. "\n")
end

coroutine_yield(false)
end

Expand Down Expand Up @@ -1093,7 +1097,10 @@ hook.Add("Think", "prop2mesh_meshlab", function()
local ok, err, mdata = coroutine.resume(lab.coro, lab.data, lab.uniqueID)

if not ok then
ErrorNoHaltWithStack("Prop2Mesh Meshlab error: " .. (tostring(err) or "<nil>"))
if devcvar:GetBool() then
ErrorNoHaltWithStack("Prop2Mesh Meshlab error: " .. (tostring(err) or "<nil>"))
end

meshlabs[key] = nil
break
end
Expand Down