Skip to content

Conversation

@nand-nor
Copy link

This PR bumps the hashbrown dep to latest (0.15.2), addresses the deprecated use of coverage_helper::tests, and adds a lint table to remove the warning emitted for the coverage_nightly attribute. The dev dependency on coverage_helper is removed in favor of the now-recommended form:

#![cfg_attr(coverage_nightly, feature(coverage_attribute))]
...
#[cfg(test)]
#[cfg_attr(coverage_nightly, coverage(off))]
mod test {
...
}

@nand-nor
Copy link
Author

cc @sgodwincs. I notice that CI is failing but has been for awhile now, the last CI run happened long ago enough that the logs have been dropped, and it looks like this PR will need workflow approval to run CI. May be failing because code coverage is just below 95% but that is a guess. Let me know if you want CI to be passing before looking at / merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant