feat: enable use of job token for gitlab api authentication #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we are waiting for the merge :) works good |
fgreinacher
requested changes
Nov 26, 2025
Contributor
There was a problem hiding this comment.
Thanks a lot @arvest-bjoneson! Please revert the formatting changes so that this is easier to review 🙇
Contributor
Kind reminder to revert the formatting @arvest-bjoneson. Will help with the review. Thanks a lot for your contribution. |
Author
My apologies for delay @fgreinacher @JonasSchubert - Formatting changes have been reverted! Many thanks. |
fgreinacher
reviewed
Dec 21, 2025
fgreinacher
reviewed
Dec 21, 2025
Contributor
There was a problem hiding this comment.
Thanks for the update @arvest-bjoneson, this looks great! Just one remaining question from my side.
fgreinacher
approved these changes
Dec 22, 2025
Author
|
My pleasure! You too. |
Contributor
|
Good to go once linter is happy 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of recommendations made in #901