Skip to content

Conversation

@plpla
Copy link
Contributor

@plpla plpla commented Oct 17, 2012

This is to allow conversion of the new MiSeq-SampleSheet format to the CASAVA-SampleSheet format.
This patch is needed because of a MiSeq(R) system upgrade.
Signed-off-by: Pier-Luc Plante pier-luc.plante.1@ulaval.ca

CASAVA-SampleSheet format.
This patch is needed because of a MiSeq(R) system upgrade.
Signed-off-by: Pier-Luc Plante <pier-luc.plante.1@ulaval.ca>
@sebhtml
Copy link
Owner

sebhtml commented Oct 17, 2012

First, the commit message should say what changed in the MiSeq format.

Second, the original file has 172 lines.

The diff --stat says 1 files changed, 177 insertions(+), 172 deletions(-),
which is ridiculous (at this point, this is not a patch, but more like a
complete re-write.

This is because new file has Windows new lines (\r\n). Please fix this to
UNIX new lines (\n).

Third, a commit message should be like:

short title

A paragraph or two, if necessary

Signed-off by line

On 17/10/12 03:19 PM, plpla wrote:

This is to allow conversion of the new MiSeq-SampleSheet format to the CASAVA-SampleSheet format.
This patch is needed because of a MiSeq(R) system upgrade.
Signed-off-by: Pier-Luc Plante pier-luc.plante.1@ulaval.ca mailto:pier-luc.plante.1@ulaval.ca


    You can merge this Pull Request by running:

git pull https://github.com/plpla/NGS-Pipelines master

Or view, comment on, or merge it at:

#3

    Commit Summary


Reply to this email directly or view it on GitHub #3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants