Skip to content

Allow dropping capabilities + prevent additional capabilities #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonhammes merged 8 commits into from
May 21, 2025
Merged

Allow dropping capabilities + prevent additional capabilities #81

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4f6780e
Allow dropping certain capabilities
simonhammes May 15, 2025
3dde0fd
Allow setting "--security-opt no-new-privileges"
simonhammes May 15, 2025
8250e28
Fix code style
simonhammes May 15, 2025
61140fd
Fix default value
simonhammes May 15, 2025
2e75cab
Fix handling of PYTHON_RUNNER_DROPPED_CAPABILITIES
simonhammes May 19, 2025
fd1dc84
Fix code style
simonhammes May 19, 2025
2287223
Fix option
simonhammes May 19, 2025
f0f60d6
Fix options
simonhammes May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions starter/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,14 @@
TMPFS_MOUNT_SIZE_IN_BYTES = os.environ.get(
"PYTHON_RUNNER_TMPFS_MOUNT_SIZE_IN_BYTES", "104857600"
)
DROPPED_CAPABILITIES = [
cap
for cap in os.environ.get("PYTHON_RUNNER_DROPPED_CAPABILITIES", "").split(",")
if cap.strip()
]
NO_NEW_PRIVILEGES = (
os.environ.get("PYTHON_RUNNER_NO_NEW_PRIVILEGES", "false").lower() == "true"
)
OTHER_OPTIONS = os.environ.get("PYTHON_RUNNER_OTHER_OPTIONS", "[]")
try:
OTHER_OPTIONS = ast.literal_eval(OTHER_OPTIONS)
Expand Down Expand Up @@ -308,6 +316,13 @@ def run_python(data):
command.extend(
["--mount", f"type=tmpfs,dst=/tmp,tmpfs-size={TMPFS_MOUNT_SIZE_IN_BYTES}"]
)
if DROPPED_CAPABILITIES:
command.extend(
f"--cap-drop={capability}" for capability in DROPPED_CAPABILITIES
)
if NO_NEW_PRIVILEGES:
# Prevent container from gaining additional privileges
command.extend(["--security-opt", "no-new-privileges"])
# other options, these options are experimental, may cause failure to start script
if OTHER_OPTIONS and isinstance(OTHER_OPTIONS, list):
for option in OTHER_OPTIONS:
Expand Down