Add fallback require modes for convert_require and bundle
#334
+1,038
−233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix `inject_global_value` rule with default value (seaofvoices#324) * Release 0.17.3 (seaofvoices#325) * Add support for property modifiers in table types (seaofvoices#332) This PR adds support for `read` and `write` access modifiers in table types. Example: ``` export type Object = { read name: string, } ``` --------- Co-authored-by: jeparlefrancais <35781636+jeparlefrancais@users.noreply.github.com>
…nto hybrid-mode
Contributor
Author
|
While testing, I noticed an issue when using both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #240
An array of
RequireModes can be passed forconvert_require'ssource, and bundle'srequire_mode. It attempts each require mode in turn, until one is successful. Furthermore, support for usingrobloxas the source require mode is now supported.convert_requirecan now acceptrobloxas a validsourceoptionconvert_requirecan now accept an array of require modes for thesourcebundlecan now accept an array of require modes forrequire_mode