-
Notifications
You must be signed in to change notification settings - Fork 18
Adde guide for visual testing #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
=======================================
Coverage 83.54% 83.54%
=======================================
Files 8 8
Lines 1689 1689
=======================================
Hits 1411 1411
Misses 278 278 |
|
CC @timtreis @Sonja-Stockhaus I made a Dockerfile to ensure reproducibility of the test plots in any local machine. I did this because I was not able to have the tests passing in my MacBook. I also updated the contribution guide to explain how to update new artifacts. |
|
If the setup via the GUI doesn't work, one can always pre-build the image manually. The command to build the image in the docker build --build-arg TARGETPLATFORM=linux/arm64 --tag test-spatialdata-plot -f test.Dockerfile . |
|
Using Docker in PyCharm was possible but not straightforward due to this bug https://youtrack.jetbrains.com/issue/PY-81541/Failed-to-configure-Docker-based-SDK-non-zero-exit-code-1?backToIssues=false. It has now been fixed in PyCharm 2025.3.1 so the config of the Docker image how I show in the screenshot above works again smoothly now. |

FYI, this is the command that I use for
act:Please notice that you have to change
arm64toamd64if you are not using Apple Silicon.It may work even without the
codecovtoken, please ask me if you encounter problem and I'll help with that.