Fix PyDESeq2 layer handling in fit() #895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PyDESeq2(..., layer=...)validates the layer at init, but.fit()passed the original AnnData to PyDESeq2, which always readsadata.X. IfXis non-integer (e.g. normalized),.fit()fails withValueError: The count matrix should only contain integers.Fix
When
layeris set, build an internal counts-only AnnData with.X = adata.layers[layer](no mutation of user.X) and pass that toDeseqDataSet.Test
Add regression test where
.Xis non-integer butlayercontains integer counts; assert.fit()succeeds and.Xis unchanged.