Skip to content

Conversation

@grst
Copy link
Contributor

@grst grst commented Nov 8, 2025

For #292, implement the following changes

  • Update schema

    • rename "authors" to "contact"
    • add a field "logo" which allows to specify an image and will be used for core packages
  • Implement extended validation

    • use python script on top of jsonschema
    • validate links, logos, github user IDs, pypy/conda/cran identifiers
    • Fix/remove broken github/pypi identifiers that were found that way
  • Update CI to use uv

The validation code is based on the script we already had in the tutorials registry: https://github.com/scverse/scverse-tutorials

Closes #69

@grst grst requested review from Zethson and flying-sheep November 8, 2025 20:26
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

I generally wonder whether it wouldn't be nicer to collect all failures for the validators and raise one or more errors at the end instead of failing early. Having to rerun this is annoying because of the many requests and we could bombard their API servers.

Co-authored-by: Lukas Heumos <lukas.heumos@posteo.net>
@grst
Copy link
Contributor Author

grst commented Nov 10, 2025

Thanks for fixing all my typos!

Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll take a quick look at hammering the API a bit less, otherwise looks great!

/edit: done, at least users per project are now batched

@flying-sheep
Copy link
Member

Errors look like this:

ValueError: palantir: Failed to validate GitHub users ['dpeerlab', 'ManuSetty', 'katosh']:
- Could not resolve to a User with the login of 'dpeerlab'.

grst added 3 commits November 15, 2025 20:03
Instead, collect all errors until the end and print all of them
@grst grst mentioned this pull request Nov 16, 2025
4 tasks
@grst grst merged commit 70eb2cc into main Nov 18, 2025
3 checks passed
@grst grst deleted the img-support branch November 18, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change definition of authors field

4 participants