-
Notifications
You must be signed in to change notification settings - Fork 65
Update schema and implement extended schema validation #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rename authors -> contact and add field for logos
Zethson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
I generally wonder whether it wouldn't be nicer to collect all failures for the validators and raise one or more errors at the end instead of failing early. Having to rerun this is annoying because of the many requests and we could bombard their API servers.
Co-authored-by: Lukas Heumos <lukas.heumos@posteo.net>
|
Thanks for fixing all my typos! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll take a quick look at hammering the API a bit less, otherwise looks great!
/edit: done, at least users per project are now batched
|
Errors look like this: ValueError: palantir: Failed to validate GitHub users ['dpeerlab', 'ManuSetty', 'katosh']:
- Could not resolve to a User with the login of 'dpeerlab'. |
Instead, collect all errors until the end and print all of them
For #292, implement the following changes
Update schema
Implement extended validation
Update CI to use uv
The validation code is based on the script we already had in the tutorials registry: https://github.com/scverse/scverse-tutorials
Closes #69