This repository was archived by the owner on Apr 18, 2025. It is now read-only.
[FIX] Chunk builder's block limit #335
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix issue
4 tasks
Collaborator
|
i guess you find this bug by set block_limit > 1? |
Member
Author
yes |
|
Try Block_limit |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When chunk builder deliver chunk data with block limit condition, the original code do not reset the ccc result.
As the result, the following
addcall would deliver a empty collection of chunks and panic.This PR fix the issue and add enviroment variant (
CHUNK_BLOCK_LIMIT) for setting the block limit of chunk builder.For not-set, thhe block limit is kept as original code (
1) and to enable unlimit of blocks, useCHUNK_BLOCK_LIMIT=0