Skip to content

Conversation

@Mouadhbendjedidi
Copy link

what i added in this pull request?

  • 164 Arabic wordlist
  • translated scribble to Arabic

@Bios-Marcel
Copy link
Member

image

Shouldn't this be right to left?

@Mouadhbendjedidi
Copy link
Author

oh yeah it should be

@Mouadhbendjedidi
Copy link
Author

i think we need to add RTL support too

@Bios-Marcel
Copy link
Member

Are you willing to try this? If I do it, I don't know when it'll be.

@DeepSpace2
Copy link
Contributor

DeepSpace2 commented Dec 30, 2025

I'm currently working on supporting RTL for specific locales as part of adding Hebrew translation and words. Assuming my PR (once opened) will be merged before this PR, it can be rebased and use my modification.

One major decision I'm facing is the fact that the locale (the language of the game UI) is decoupled from the wordpack language meaning the UI might be in a non-RTL language while the chosen wordpack is in an RTL language. This is an issue because we need to detect the RTL-ness of the locale and the wordpack languages individually because if we simply slap dir="rtl/ltr" on body the hint might be in the wrong direction.

@Bios-Marcel
Copy link
Member

Can't we jusy apply a separate direction tag for the components that display words?

@DeepSpace2
Copy link
Contributor

DeepSpace2 commented Dec 31, 2025

@Bios-Marcel I prefer (and like) the entire UI becoming right-to-left by applying dir="rtl" to body:

image

This logic just needs to be separated from the dir we apply to <div id="word-container"> for the reason I mentioned above.

I'm pretty much there with the implementation. I'll open a separated PR when I'm ready in order to not completely hijack this thread :)

@Bios-Marcel
Copy link
Member

Hey, I merged #388, do you mind rebasing and adjusting the PR? @Mouadhbendjedidi

@Mouadhbendjedidi
Copy link
Author

Hello! sorry for the late

i will do that for sure! but i got some issues with our internet provider and i'm waiting for a fix for that. i will try to free my time for the pull request!

thanks @DeepSpace2 for RTL support btw

@Mouadhbendjedidi
Copy link
Author

Mouadhbendjedidi commented Jan 8, 2026

everything seems now to be okay now, but i still have to test it, so when i fix the network issue i will confirm the changes!

thanks again for @DeepSpace2 for his explanation on his pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants