-
Notifications
You must be signed in to change notification settings - Fork 200
Feat(language): Added Arabic language support + wordlist #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
oh yeah it should be |
|
i think we need to add RTL support too |
|
Are you willing to try this? If I do it, I don't know when it'll be. |
|
I'm currently working on supporting RTL for specific locales as part of adding Hebrew translation and words. Assuming my PR (once opened) will be merged before this PR, it can be rebased and use my modification. One major decision I'm facing is the fact that the locale (the language of the game UI) is decoupled from the wordpack language meaning the UI might be in a non-RTL language while the chosen wordpack is in an RTL language. This is an issue because we need to detect the RTL-ness of the locale and the wordpack languages individually because if we simply slap |
|
Can't we jusy apply a separate direction tag for the components that display words? |
|
@Bios-Marcel I prefer (and like) the entire UI becoming right-to-left by applying
This logic just needs to be separated from the I'm pretty much there with the implementation. I'll open a separated PR when I'm ready in order to not completely hijack this thread :) |
|
Hey, I merged #388, do you mind rebasing and adjusting the PR? @Mouadhbendjedidi |
|
Hello! sorry for the late i will do that for sure! but i got some issues with our internet provider and i'm waiting for a fix for that. i will try to free my time for the pull request! thanks @DeepSpace2 for RTL support btw |
|
everything seems now to be okay now, but i still have to test it, so when i fix the network issue i will confirm the changes! thanks again for @DeepSpace2 for his explanation on his pull request! |


what i added in this pull request?