fix(eye): guard missing model instance #7180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielchristiancazares
force-pushed
the
fix/object-get-eye-guard
branch
from
97b0feb to
1151028
Compare
Log once and fall back when object_get_eye lacks a model instance.
danielchristiancazares
force-pushed
the
fix/object-get-eye-guard
branch
from
1151028 to
c6af44f
Compare
Goober5000
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guard: Add a defensive guard when object_get_eye has a model without a model instance. Then, log once with object details, assert in debug, and fall back to origin/identity to avoid a hard crash.
Some object types are allowed to programmatically have a model without an instance (e.g. weapons, debris, asteroids, jump nodes). object_get_eye now handles non‑ship objects as to prevent a null deref in aberrant edge cases.