Added test pipeline and lint #2

SylvainSenechal · 2025-12-01T10:51:54Z

bert-e · 2025-12-01T10:51:58Z

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

SylvainSenechal · 2025-12-01T10:56:31Z

.github/workflows/test.yml

+      - name: Wait for metadata to be ready
+        run: |
+          set -o pipefail
+          bash .github/workflows/wait_for_local_port.bash 9000 40


Stolen from https://github.com/scality/cloudserver/blob/development/9.1/wait_for_local_port.bash 🌚

SylvainSenechal · 2025-12-01T10:57:37Z

.github/md-config.json

Also stolen from cloudserver, need it to run metadata backend

bert-e · 2025-12-01T11:11:14Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

tests/testMultipleBackendApis.test.ts

.github/workflows/test.yml

tests/testMultipleBackendApis.test.ts

DarkIsDude · 2025-12-02T09:12:19Z

.eslintrc.js

@@ -0,0 +1,26 @@
+module.exports = {
+  parser: '@typescript-eslint/parser',


I think we have a scality one too ?

Not too sure about this, on other codebases i see an eslint.config.mjs file that's more complex, don't know if I should use something similar or not

I prefer yours to be honest but. i think we can extends also the one from scality. It's just an extends, so should be fine ?

i extended the one from scality

package.json

benzekrimaha · 2025-12-04T05:40:11Z

.github/docker-compose.cloudserver-metadata.yml

+
+  cloudserver-metadata:
+    image: ghcr.io/scality/cloudserver:9.1.4
+    platform: linux/amd64


is this really needed ? ( it's mac specific I think )

Ah yeah, so it's indeed useless for the ci, but for mac dev who wants to start the docker-compose locally, it will be useful so that's why I added it

benzekrimaha · 2025-12-09T14:50:37Z

.eslintrc.js

+    '@typescript-eslint/no-explicit-any': 'warn',
+    '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],


Are we sure we only want these two rules ?

actually im gonna extend the scality linter, hold on

benzekrimaha · 2025-12-09T14:51:55Z

.github/docker-compose.cloudserver-mongo.yml

+      - MONGODB_HOSTS=mongodb:27018
+      - MONGODB_RS=rs0
+      - REMOTE_MANAGEMENT_DISABLE=true
+      - SCALITY_ACCESS_KEY_ID=accessKey1


not sure it's very safe to put this here in general => should be a secret instead

Removed, actually not needed at all since they are used by default when not provided

ISSUE: CLDSRVCLT-2

SylvainSenechal commented Dec 1, 2025

View reviewed changes

.github/md-config.json

Copy link

Contributor Author

SylvainSenechal Dec 1, 2025 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also stolen from cloudserver, need it to run metadata backend

scality deleted a comment from bert-e Dec 1, 2025

SylvainSenechal requested review from a team, DarkIsDude and benzekrimaha December 1, 2025 11:11

scality deleted a comment from bert-e Dec 1, 2025

SylvainSenechal commented Dec 1, 2025

View reviewed changes

tests/testMultipleBackendApis.test.ts Show resolved Hide resolved

SylvainSenechal force-pushed the improvement/CLDSRVCLT-2 branch 2 times, most recently from 7fa7e8b to 96e82f2 Compare December 1, 2025 11:29

SylvainSenechal marked this pull request as ready for review December 1, 2025 11:31

SylvainSenechal force-pushed the improvement/CLDSRVCLT-2 branch 2 times, most recently from c63bfee to 22f1240 Compare December 1, 2025 15:57

DarkIsDude reviewed Dec 2, 2025

View reviewed changes

SylvainSenechal force-pushed the improvement/CLDSRVCLT-2 branch 2 times, most recently from 17dca6a to b424f76 Compare December 3, 2025 11:06

benzekrimaha reviewed Dec 4, 2025

View reviewed changes

SylvainSenechal requested review from DarkIsDude and benzekrimaha December 4, 2025 15:52

DarkIsDude approved these changes Dec 5, 2025

View reviewed changes

benzekrimaha reviewed Dec 9, 2025

View reviewed changes

SylvainSenechal added 2 commits December 9, 2025 17:39

cleanup tests

cb2ba4f

ISSUE: CLDSRVCLT-2

add linter

534ca01

ISSUE: CLDSRVCLT-2

SylvainSenechal force-pushed the improvement/CLDSRVCLT-2 branch from de57b47 to 0b8ba1f Compare December 9, 2025 16:43

SylvainSenechal added 2 commits December 9, 2025 18:09

add test pipeline

0b809b0

ISSUE: CLDSRVCLT-2

run lint and typecheck on ci

701bdfa

ISSUE: CLDSRVCLT-2

SylvainSenechal force-pushed the improvement/CLDSRVCLT-2 branch from 8dd3788 to 58ae441 Compare December 9, 2025 17:09

scality deleted a comment from bert-e Dec 10, 2025

SylvainSenechal added 2 commits December 10, 2025 11:40

use scality guidelines as linting rules

3c5af82

ISSUE: CLDSRVCLT-2

comply with linter

dbfab6d

ISSUE: CLDSRVCLT-2

SylvainSenechal force-pushed the improvement/CLDSRVCLT-2 branch from 58ae441 to dbfab6d Compare December 10, 2025 10:40

		@@ -0,0 +1,26 @@
		module.exports = {
		parser: '@typescript-eslint/parser',

		'@typescript-eslint/no-explicit-any': 'warn',
		'@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],

Added test pipeline and lint #2

Are you sure you want to change the base?

Added test pipeline and lint #2

Conversation

SylvainSenechal commented Dec 1, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Dec 1, 2025

Hello sylvainsenechal,

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SylvainSenechal Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bert-e commented Dec 1, 2025

Waiting for approval

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SylvainSenechal commented Dec 1, 2025 •

edited by atlassian bot

Loading

SylvainSenechal Dec 1, 2025 •

edited

Loading