fix: simplify types before checking if implicit is underspecified #24659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
commented
Dec 4, 2025
| tp.isRef(defn.NothingClass) || tp.isRef(defn.NullClass) || (tp eq NoPrefix) | ||
|
|
||
| private def isUnderspecified(tp: Type): Boolean = tp.stripTypeVar match | ||
| private def isUnderspecified(tp: Type): Boolean = tp.simplified match |
Member
Author
There was a problem hiding this comment.
I'm willing to bet that we also need a dealiasing here.
hamzaremmal
commented
Dec 4, 2025
| || isUnderSpecifiedArgument(tp.argType.widen) | ||
| case _ => | ||
| tp.isAny || tp.isAnyRef | ||
| case tp => tp.isAny || tp.isAnyRef || tp.isAnyVal |
Member
Author
There was a problem hiding this comment.
From a specification point of view, it would have been nice to check tp.isTopLevel but that means we need to also include scala.Matchable in the list of underspecified types.
hamzaremmal
commented
Dec 4, 2025
Comment on lines
+9
to
+20
| | One of the following imports might fix the problem: | ||
| | | ||
| | import scala.math.BigDecimal.int2bigDecimal | ||
| | import scala.math.BigInt.int2bigInt | ||
| | import scala.math.Numeric.IntIsIntegral.mkNumericOps | ||
| | import scala.math.Numeric.IntIsIntegral.mkOrderingOps | ||
| | import scala.math.Ordering.Int.mkOrderingOps | ||
| | import scala.math.Integral.Implicits.infixIntegralOps | ||
| | import scala.math.Ordered.orderingToOrdered | ||
| | import scala.math.Ordering.Implicits.infixOrderingOps | ||
| | import scala.math.Numeric.Implicits.infixNumericOps | ||
| | import scala.reflect.Selectable.reflectiveSelectable |
Member
Author
There was a problem hiding this comment.
None of them will ever help. An improvement would be to get rid of this list when we are underspecified.
hamzaremmal
commented
Dec 4, 2025
| implicit def _2: Int = 0 | ||
|
|
||
| println(implicitly[AnyVal]) | ||
| println(implicitly[AnyVal]) // error |
Member
Author
There was a problem hiding this comment.
This test was completely bogus before, not only it should have been underspecified but also, if we say AnyVal are not underspecified, it should have been an ambiguous resolution (what actually Scala 2.13.16 says).
hamzaremmal
commented
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21304