Skip to content

Lint enum case in outer context #24652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
som-snytt merged 1 commit into from
Dec 8, 2025
Merged

Lint enum case in outer context #24652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion compiler/src/dotty/tools/dotc/transform/CheckUnused.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ class CheckUnused private (phaseMode: PhaseMode, suffix: String) extends MiniPha
if !tree.symbol.is(Deferred) && tree.rhs.symbol != defn.Predef_undefined then
register(tree)
relax(tree.rhs, tree.tpt.tpe)
ctx
if tree.symbol.isAllOf(EnumCase) then ctx.outer else ctx
override def transformValDef(tree: ValDef)(using Context): tree.type =
traverseAnnotations(tree.symbol)
if tree.name.startsWith("derived$") && tree.hasType then
Expand Down Expand Up @@ -222,6 +222,8 @@ class CheckUnused private (phaseMode: PhaseMode, suffix: String) extends MiniPha
resolveUsage(defn.Compiletime_deferred, nme.NO_NAME, NoPrefix)
tree

override def prepareForTypeDef(tree: TypeDef)(using Context): Context =
if tree.symbol.isAllOf(EnumCase) then ctx.outer else ctx
override def transformTypeDef(tree: TypeDef)(using Context): tree.type =
traverseAnnotations(tree.symbol)
if !tree.symbol.is(Param) then // type parameter to do?
Expand Down
13 changes: 13 additions & 0 deletions tests/warn/i24646.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
//> using options -Wunused:all

import Test.OnlyFirst
import Test.OnlyThird

enum Test:
case First extends Test with OnlyFirst
case Second extends Test
case Third(s: String) extends Test with OnlyThird

object Test:
sealed trait OnlyFirst
sealed trait OnlyThird
Loading