Skip to content

Conversation

@sblunt
Copy link
Owner

@sblunt sblunt commented Jul 17, 2025

Not everything is working yet but I want to test the automatic notebook running workflow which triggers on pr to main

@sblunt sblunt requested a review from semaphoreP July 17, 2025 17:46
@sblunt
Copy link
Owner Author

sblunt commented Jul 17, 2025

All right, assuming tests pass, I think everything is working now. Main changes I made:

  • moved most of the pip setup code from setup.py to pyproject.toml. It seems like pyproject.toml still doesn't have a clean functionality to compile cython code, so I'll keep that part and a setup.py for now
  • debugged two tests (one jupyter notebook and one multiprocessing one that was failing on my mac)

Copy link
Collaborator

@semaphoreP semaphoreP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Feel free to merge

@sblunt sblunt merged commit 0e05e59 into main Jul 18, 2025
1 of 9 checks passed
@sblunt sblunt deleted the pyproject.toml branch July 18, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants