Skip to content

Conversation

@notandy
Copy link
Contributor

@notandy notandy commented Dec 18, 2025

This add the check plugin hypervisorCondition, which works the same way as the Condition plugin, excepts it's checking hypervisor condition instead of node conditions.
This gives us more flexibility than the checkHypervisor plugin.

@notandy
Copy link
Contributor Author

notandy commented Dec 18, 2025

fyi @fwiesel

Copy link
Collaborator

@Nuckal777 Nuckal777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugin needs to be added to the registry, looks good otherwise.

@notandy
Copy link
Contributor Author

notandy commented Dec 19, 2025

Plugin needs to be added to the registry, looks good otherwise.

always forgetting that, thanks!

@notandy notandy force-pushed the hypervisor-condition branch from 6d976c8 to 6eb2f29 Compare December 19, 2025 15:05
@notandy notandy requested a review from Nuckal777 December 19, 2025 15:05
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/sapcc/maintenance-controller/controllers 85.87% (ø)
github.com/sapcc/maintenance-controller/plugin/impl 81.55% (+0.22%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/sapcc/maintenance-controller/controllers/config.go 81.54% (ø) 65 53 12
github.com/sapcc/maintenance-controller/plugin/impl/hypervisor.go 94.74% (-0.32%) 95 (+14) 90 (+13) 5 (+1) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/sapcc/maintenance-controller/plugin/impl/hypervisor_test.go

@Nuckal777 Nuckal777 merged commit 6e90bff into master Dec 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants