475: VTT reader does not display cues with negative line attribute values #476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integer line values can be positive or negative. When positive, lines are counted from the top of the screen, and when negative, from the bottom of the screen.
The code did not handle negative values correctly, as line positions ended up greater than 100(%), hence out of the screen.
The fix handles negative values properly and adds a test case for both positive/negative integers and percentage.
Note that line value 0 should probably be handled as a positive value, but I did not change the current logic to remain backward compatible.
Closes #475