Fix PixelFormat's Stride calculation to account for framebuffer inconsistency. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sistency. On my laptop running vanilla Debian Sid, my framebuffer uses 32 bits per pixel, but the 4th byte isn't used for alpha. The alpha channel's length and offset are both 0. That throws off the PixelFormat.Stride function, making it think that the framebuffer format is only 24bpp. So I changed PixelFormat to have an addition Depth field that gets set from fb_var_screeninfo.bits_per_pixel and all's well now.
Author
|
Attempted to update the Stride calculation with the rpi-friendly line, but not entirely sure what's going on with the rpi so not entirely sure if this is the right move for it or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my laptop running vanilla Debian Sid, my framebuffer uses 32 bits per pixel,
but the 4th byte isn't used for alpha. The alpha channel's length and offset
are both 0.
That throws off the PixelFormat.Stride function, making it think that the
framebuffer format is only 24bpp. So I changed PixelFormat to have an
addition Depth field that gets set from fb_var_screeninfo.bits_per_pixel and
all's well now.