the previous patch fixed some issues with slate editing, but would randomly result in loss sometimes when multiple people are editing at once, so address that

Author: williamstein

src/packages/frontend/editors/slate/editable-markdown.tsx

@@ -155,7 +155,7 @@ export const EditableMarkdown: React.FC<Props> = React.memo((props: Props) => {
     placeholder,
     read_only,
     registerEditor,
-    saveDebounceMs,
+    saveDebounceMs = SAVE_DEBOUNCE_MS,
     selectionRef,
     style,
     submitMentionsRef,
@@ -257,7 +257,7 @@ export const EditableMarkdown: React.FC<Props> = React.memo((props: Props) => {
   // hook up to syncstring if available:
   useEffect(() => {
     if (actions._syncstring == null) return;
-    const beforeChange = setSyncstringFromSlate;
+    const beforeChange = setSyncstringFromSlateNOW;
     const change = () => {
       setEditorToValue(actions._syncstring.to_str());
     };
@@ -496,29 +496,31 @@ export const EditableMarkdown: React.FC<Props> = React.memo((props: Props) => {
     }
   }, [value]);
 
-  const setSyncstringFromSlate = useMemo(() => {
-    const f = () => {
-      if (actions.set_value == null) {
-        // no way to save the value out (e.g., just beginning to test
-        // using the component).
-        return;
-      }
-      if (!editor.hasUnsavedChanges()) {
-        // there are no changes to save
-        return;
-      }
+  const setSyncstringFromSlateNOW = () => {
+    if (actions.set_value == null) {
+      // no way to save the value out (e.g., just beginning to test
+      // using the component).
+      return;
+    }
+    if (!editor.hasUnsavedChanges()) {
+      // there are no changes to save
+      return;
+    }
 
-      const markdown = editor.getMarkdownValue();
-      actions.set_value(markdown);
-      actions.syncstring_commit?.();
+    const markdown = editor.getMarkdownValue();
+    actions.set_value(markdown);
+    actions.syncstring_commit?.();
 
-      // Record that the syncstring's value is now equal to ours:
-      editor.resetHasUnsavedChanges();
-    };
+    // Record that the syncstring's value is now equal to ours:
+    editor.resetHasUnsavedChanges();
+  };
+
+  const setSyncstringFromSlate = useMemo(() => {
     if (saveDebounceMs) {
-      return debounce(f, saveDebounceMs);
+      return debounce(setSyncstringFromSlateNOW, saveDebounceMs);
     } else {
-      return f;
+      // this case shouldn't happen
+      return setSyncstringFromSlateNOW;
     }
   }, []);
 

src/packages/frontend/editors/task-editor/desc-editor.tsx

@@ -59,6 +59,7 @@ export default function DescriptionEditor({
   return (
     <div>
       <MarkdownInput
+        saveDebounceMs={SAVE_DEBOUNCE_MS}
         cacheId={task_id}
         value={desc}
         onChange={(desc) => {