save debounce wasn't properly honored in some cases for slate editor

Author: williamstein

src/packages/frontend/editors/markdown-input/multimode.tsx

@@ -85,7 +85,9 @@ interface Props {
   submitMentionsRef?: SubmitMentionsRef;
   extraHelp?: ReactNode;
   hideHelp?: boolean;
-  saveDebounceMs?: number; // debounce how frequently get updates from onChange; if saveDebounceMs=0 get them on every change.  Default is the global SAVE_DEBOUNCE_MS const.
+  // debounce how frequently get updates from onChange; if saveDebounceMs=0 get them on every change.  Default is the global SAVE_DEBOUNCE_MS const.
+  // can be a little more frequent in case of shift or alt enter, or blur.
+  saveDebounceMs?: number;
   onBlur?: () => void;
   onFocus?: () => void;
   minimal?: boolean;

src/packages/frontend/editors/slate/editable-markdown.tsx

@@ -496,24 +496,31 @@ export const EditableMarkdown: React.FC<Props> = React.memo((props: Props) => {
     }
   }, [value]);
 
-  function setSyncstringFromSlate() {
-    if (actions.set_value == null) {
-      // no way to save the value out (e.g., just beginning to test
-      // using the component).
-      return;
-    }
-    if (!editor.hasUnsavedChanges()) {
-      // there are no changes to save
-      return;
-    }
+  const setSyncstringFromSlate = useMemo(() => {
+    const f = () => {
+      if (actions.set_value == null) {
+        // no way to save the value out (e.g., just beginning to test
+        // using the component).
+        return;
+      }
+      if (!editor.hasUnsavedChanges()) {
+        // there are no changes to save
+        return;
+      }
 
-    const markdown = editor.getMarkdownValue();
-    actions.set_value(markdown);
-    actions.syncstring_commit?.();
+      const markdown = editor.getMarkdownValue();
+      actions.set_value(markdown);
+      actions.syncstring_commit?.();
 
-    // Record that the syncstring's value is now equal to ours:
-    editor.resetHasUnsavedChanges();
-  }
+      // Record that the syncstring's value is now equal to ours:
+      editor.resetHasUnsavedChanges();
+    };
+    if (saveDebounceMs) {
+      return debounce(f, saveDebounceMs);
+    } else {
+      return f;
+    }
+  }, []);
 
   // We don't want to do saveValue too much, since it presumably can be slow,
   // especially if the document is large. By debouncing, we only do this when

src/packages/frontend/editors/slate/sync.ts

@@ -39,7 +39,7 @@ export function slatePointToMarkdown(
   try {
     [node] = Editor.node(editor, point);
   } catch (err) {
-    console.warn(`slate -- invalid point ${JSON.stringify(point)} -- ${err}`);
+    // console.warn(`slate -- invalid point ${JSON.stringify(point)} -- ${err}`);
     // There is no guarantee that point is valid when this is called.
     return { index: -1, markdown: "" };
   }