Protoype of refactoring work with Test code too. Pushing these commit… #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for a draft PR.
JohnMcPMS
reviewed
Mar 19, 2021
JohnMcPMS
reviewed
Mar 19, 2021
JohnMcPMS
reviewed
Mar 19, 2021
JohnMcPMS
reviewed
Mar 19, 2021
JohnMcPMS
reviewed
Mar 19, 2021
JohnMcPMS
reviewed
Mar 19, 2021
src/AppInstallerCLI/main.cpp
Outdated
| { | ||
| return AppInstaller::CLI::CoreMain(argc, argv); | ||
| AppInstaller::CLI::TestCOMScenario(); | ||
| return 0; |
There was a problem hiding this comment.
You could just write a unit test to do this, and it might be something work checking in.
JohnMcPMS
reviewed
Mar 19, 2021
JohnMcPMS
reviewed
Mar 19, 2021
JohnMcPMS
reviewed
Mar 19, 2021
JohnMcPMS
reviewed
Mar 19, 2021
JohnMcPMS
reviewed
Mar 19, 2021
JohnMcPMS
reviewed
Mar 19, 2021
JohnMcPMS
reviewed
Mar 19, 2021
JohnMcPMS
reviewed
Mar 19, 2021
JohnMcPMS
reviewed
Mar 19, 2021
JohnMcPMS
reviewed
Mar 22, 2021
JohnMcPMS
reviewed
Mar 22, 2021
JohnMcPMS
reviewed
Mar 22, 2021
JohnMcPMS
reviewed
Mar 22, 2021
JohnMcPMS
reviewed
Mar 22, 2021
sachintaMSFT
commented
Mar 25, 2021
|
Seems good to make the real PR; no guarantees that I won't have comments there, but they won't be major. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protoype of refactoring work with Test code too. Pushing these commits for a draft PR.