Sync #1
Open
Sync #1
+1,178,299
−9,039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaloCDB: Add HIST_CALOFITTINGQA for ZS Cross-Calibration
feat: turn on 4d tracking mode by default
Remove intt odbcquery
Fix streaming macro
Clang tidy 1
fix include file ordering in G4_ActsGeom.C
Make Temp query macro stable
Add macros for final T-corr HCal calibration
fix lamination correction to cdb
JetQA pp switch
Remove frequent filesystem checking in run.sh following feedback (from Chris), to reduce load on condor.
clean run.sh
do not run vertexpropagator when convertseed is true
updated for run25pp
feat: switch to iterative silicon seed by default
refactor: separate track matching functions
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive set of calibration and production macros for the sPHENIX experiment, focusing on calorimeter calibrations and tracking production workflows.
- Adds EMCal pi0 calibration workflows for both year 1 and year 2 runs
- Adds systematic uncertainty generation tools for calorimeter subsystems
- Adds trigger and tracking production scripts for run3pp and run3auau configurations
Reviewed changes
Copilot reviewed 161 out of 444 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| calibrations/calo/emcal_calib_year2/* | Year 2 EMCal pi0 calibration workflow with condor submission and iterative fitting |
| calibrations/calo/emcal_calib_year1/* | Year 1 EMCal calibration including tower slope and pi0 methods with track-based analysis |
| calibrations/calo/calo_cdb/* | Automated CDB map generation with database querying and condor submission |
| calibrations/calo/calo_syst/* | Systematic uncertainty generation for calorimeter calibrations |
| TrackingProduction/run3pp/* | Run3 pp tracking production with KFParticle reconstruction |
| TrackingProduction/run3auau/* | Run3 AuAu tracking production with endpoint-aware TPC unpacking |
| TriggerProduction/* | Trigger event combining with GL1 synchronization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| This set of macros runs the EMCal pi0 calibration which is ran over a user defined set of DSTs/runs and produces a C DBTTREE which is the calibration. | ||
|
|
||
| doFitAndCalibUpdate.C | ||
| This does the fitting of the pi0 peak, compares it to the target mass and generates a new calibration with which will obtain target mass with subsiquant runnings over the data. |
There was a problem hiding this comment.
Corrected spelling of 'subsiquant' to 'subsequent'.
Suggested change
| This does the fitting of the pi0 peak, compares it to the target mass and generates a new calibration with which will obtain target mass with subsiquant runnings over the data. | |
| This does the fitting of the pi0 peak, compares it to the target mass and generates a new calibration with which will obtain target mass with subsequent runnings over the data. |
Comment on lines
+7
to
+8
| This contains the area where the condor jobs are submitted and the multi-step proceedure is executed via run.sh. | ||
| To exicute the proceedure do sh run.sh |
There was a problem hiding this comment.
Corrected spelling of 'exicute' to 'execute' and 'proceedure' to 'procedure'.
Suggested change
| This contains the area where the condor jobs are submitted and the multi-step proceedure is executed via run.sh. | |
| To exicute the proceedure do sh run.sh | |
| This contains the area where the condor jobs are submitted and the multi-step procedure is executed via run.sh. | |
| To execute the procedure do sh run.sh |
| run.sh contains the logic of how the calibration proceeds. | ||
|
|
||
| Fun4All_EMCal.C | ||
| This is the main histogram-making Fun4All macro and is run over condor generally. It takes arguements of the path to the calibration file to use, a DST file list, number of events to process, and the iteration number (only usered for output naming purposes). |
There was a problem hiding this comment.
Corrected spelling of 'arguements' to 'arguments' and 'usered' to 'used'.
Suggested change
| This is the main histogram-making Fun4All macro and is run over condor generally. It takes arguements of the path to the calibration file to use, a DST file list, number of events to process, and the iteration number (only usered for output naming purposes). | |
| This is the main histogram-making Fun4All macro and is run over condor generally. It takes arguments of the path to the calibration file to use, a DST file list, number of events to process, and the iteration number (only used for output naming purposes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.