Skip to content

Skip checking if key exists in parent state #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordyvandomselaar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip checking if key exists in parent state #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions build/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,9 +314,7 @@ var SimpleStorage = function (_Component) {

// update parent's state with the result
// store.js handles parsing
if (name in parent.state) {
parent.setState(_defineProperty({}, name, value));
}
parent.setState(_defineProperty({}, name, value));
}
});

Expand Down
4 changes: 1 addition & 3 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,7 @@ export default class SimpleStorage extends Component {

// update parent's state with the result
// store.js handles parsing
if (name in parent.state) {
parent.setState({ [name]: value });
}
parent.setState({ [name]: value });
}
});

Expand Down