Start basic SCT support #423
Open
+196
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
force-pushed
the
jbp-sct
branch
2 times, most recently
from
842a112 to
e918319
Compare
djc
commented
Dec 11, 2025
Comment on lines
+58
to
+61
| #[allow(dead_code)] // pending sct verification | ||
| extensions: untrusted::Input<'a>, | ||
| #[allow(dead_code)] // pending sct verification | ||
| signature_algorithm: u16, | ||
| #[allow(dead_code)] // pending sct verification | ||
| signature: untrusted::Input<'a>, |
Member
Author
There was a problem hiding this comment.
What kind of verification needs to happen? Thoughts on a testing strategy?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
==========================================
- Coverage 97.05% 95.26% -1.80%
==========================================
Files 20 21 +1
Lines 4247 4331 +84
==========================================
+ Hits 4122 4126 +4
- Misses 125 205 +80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Dirkjan Ochtman <dirkjan@ochtman.nl>
This (or precisely the hash of it) is used as an identifier to scope the serial number of a given end-entity cert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.