Skip to content

Allow inlining of fns where the implementation is compile-time selected #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hkratz merged 1 commit into from
Dec 9, 2025
Merged

Allow inlining of fns where the implementation is compile-time selected #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions inlining/expected-methods-armv7-neon.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
simdutf8::implementation::armv7::validate_utf8_basic
simdutf8::implementation::armv7::validate_utf8_basic_neon
simdutf8::implementation::armv7::validate_utf8_compat
simdutf8::implementation::armv7::validate_utf8_compat_neon
simdutf8::implementation::helpers::get_compat_error
2 changes: 0 additions & 2 deletions inlining/expected-methods-x86-nostd-avx2.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
simdutf8::implementation::helpers::get_compat_error
simdutf8::implementation::x86::validate_utf8_basic
simdutf8::implementation::x86::validate_utf8_basic_avx2
simdutf8::implementation::x86::validate_utf8_compat
simdutf8::implementation::x86::validate_utf8_compat_avx2
2 changes: 0 additions & 2 deletions inlining/expected-methods-x86-nostd-avx512.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
simdutf8::implementation::helpers::get_compat_error
simdutf8::implementation::x86::validate_utf8_basic
simdutf8::implementation::x86::validate_utf8_basic_avx512
simdutf8::implementation::x86::validate_utf8_compat
simdutf8::implementation::x86::validate_utf8_compat_avx512
2 changes: 0 additions & 2 deletions inlining/expected-methods-x86-nostd-sse42.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
simdutf8::implementation::helpers::get_compat_error
simdutf8::implementation::x86::validate_utf8_basic
simdutf8::implementation::x86::validate_utf8_basic_sse42
simdutf8::implementation::x86::validate_utf8_compat
simdutf8::implementation::x86::validate_utf8_compat_sse42
2 changes: 0 additions & 2 deletions inlining/expected-methods-x86-std-avx2.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
simdutf8::implementation::helpers::get_compat_error
simdutf8::implementation::x86::validate_utf8_basic
simdutf8::implementation::x86::validate_utf8_basic_avx2
simdutf8::implementation::x86::validate_utf8_compat
simdutf8::implementation::x86::validate_utf8_compat_avx2
2 changes: 0 additions & 2 deletions inlining/expected-methods-x86-std-avx512.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
simdutf8::implementation::helpers::get_compat_error
simdutf8::implementation::x86::validate_utf8_basic
simdutf8::implementation::x86::validate_utf8_basic_avx512
simdutf8::implementation::x86::validate_utf8_compat
simdutf8::implementation::x86::validate_utf8_compat_avx512
2 changes: 2 additions & 0 deletions src/implementation/armv7/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ pub(crate) unsafe fn validate_utf8_basic(
// validate_utf8_basic() no-std: implementation selection by config

#[cfg(all(feature = "armv7_neon", target_feature = "neon"))]
#[inline]
pub(crate) unsafe fn validate_utf8_basic(
input: &[u8],
) -> core::result::Result<(), crate::basic::Utf8Error> {
Expand Down Expand Up @@ -112,6 +113,7 @@ pub(crate) unsafe fn validate_utf8_compat(
// validate_utf8_basic() no-std: implementation selection by config

#[cfg(all(feature = "armv7_neon", target_feature = "neon"))]
#[inline]
pub(crate) unsafe fn validate_utf8_compat(
input: &[u8],
) -> core::result::Result<(), crate::compat::Utf8Error> {
Expand Down
6 changes: 6 additions & 0 deletions src/implementation/x86/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ pub(crate) unsafe fn validate_utf8_basic(
target_feature = "avx512vbmi",
target_feature = "avx512vbmi2"
))]
#[inline]
pub(crate) unsafe fn validate_utf8_basic(
input: &[u8],
) -> core::result::Result<(), crate::basic::Utf8Error> {
Expand Down Expand Up @@ -187,6 +188,7 @@ unsafe fn validate_utf8_basic_avx512(
),
all(target_feature = "avx2", feature = "std", not(avx512_stable))
))]
#[inline]
pub(crate) unsafe fn validate_utf8_basic(
input: &[u8],
) -> core::result::Result<(), crate::basic::Utf8Error> {
Expand Down Expand Up @@ -230,6 +232,7 @@ unsafe fn validate_utf8_basic_avx2(
not(target_feature = "avx2"),
target_feature = "sse4.2"
))]
#[inline]
pub(crate) unsafe fn validate_utf8_basic(
input: &[u8],
) -> core::result::Result<(), crate::basic::Utf8Error> {
Expand Down Expand Up @@ -356,6 +359,7 @@ pub(crate) unsafe fn validate_utf8_compat(
target_feature = "avx512vbmi",
target_feature = "avx512vbmi2"
))]
#[inline]
pub(crate) unsafe fn validate_utf8_compat(
input: &[u8],
) -> core::result::Result<(), crate::compat::Utf8Error> {
Expand Down Expand Up @@ -390,6 +394,7 @@ unsafe fn validate_utf8_compat_avx512(
),
all(target_feature = "avx2", feature = "std", not(avx512_stable))
))]
#[inline]
pub(crate) unsafe fn validate_utf8_compat(
input: &[u8],
) -> core::result::Result<(), crate::compat::Utf8Error> {
Expand Down Expand Up @@ -433,6 +438,7 @@ unsafe fn validate_utf8_compat_avx2(
not(target_feature = "avx2"),
target_feature = "sse4.2"
))]
#[inline]
pub(crate) unsafe fn validate_utf8_compat(
input: &[u8],
) -> core::result::Result<(), crate::compat::Utf8Error> {
Expand Down