Skip to content

Conversation

@devnexen
Copy link
Contributor

@devnexen devnexen commented Jun 12, 2024

Since we support solaris 11 as minimum, we can get rid of the runtime overhead.

try-job: dist-various-2

@rustbot
Copy link
Collaborator

rustbot commented Jun 12, 2024

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 12, 2024
@rust-log-analyzer

This comment has been minimized.

@ChrisDenton
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 12, 2024

📌 Commit 075f068 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2024
@workingjubilee
Copy link
Member

workingjubilee commented Jun 13, 2024

failed in #126369 with dist-various-2:

   error: unused import: `libc::c_char`
    --> library/std/src/sys/pal/unix/fs.rs:35:5
     |
  35 | use libc::c_char;
     |     ^^^^^^^^^^^^
     |
     = note: `-D unused-imports` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(unused_imports)]`

@workingjubilee
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 13, 2024
@workingjubilee
Copy link
Member

Please request a bors-try attempt after this patch is fixed and before it is r+'d again.

Since we support solaris 11 and macOs Sierra as minimum, we can get rid
of the runtime overhead.
@devnexen
Copy link
Contributor Author

@bors try

@bors
Copy link
Collaborator

bors commented Jun 13, 2024

@devnexen: 🔑 Insufficient privileges: not in try users

@workingjubilee
Copy link
Member

tfw you can't assign people permissions piecemeal.

@bors try

@bors
Copy link
Collaborator

bors commented Jun 13, 2024

⌛ Trying commit c81ffab with merge b7d907c...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants