minor: Remove Rust ungram file from the Ungrammar repo #21285
Merged
+0
−677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
It can be confused with the real Rust ungram, now that they're in the same repo.
ChayimFriedman2
force-pushed
the
remove-rust-outdated-ungram
branch
from
ec0c778 to
32d5092
Compare
Member
|
I was confused by this several times 😅 But I'm not sure whether the crate itself needs it |
Contributor
Author
What do you mean? |
Member
|
I mean, will it break something, as there might be some reason it exists there 😅 |
Contributor
Author
|
AFAIK it is just an example of how to use the crate. |
ShoyuVanilla
approved these changes
Dec 17, 2025
Member
ShoyuVanilla
left a comment
ShoyuVanilla
left a comment
There was a problem hiding this comment.
AFAIK it is just an example of how to use the crate.
Yeah, it seems so. Though it exposes fn rust_grammar() as a public API, rust.ungram file is already a year old, the last release for ungrammar in crates.io is more than 3 years old and every dependent of it seems not using that API. So I think this is okay to remove.
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be confused with the real Rust ungram, now that they're in the same repo.
I don't want to self-approve this, in case someone disagrees.