Skip to content

Conversation

@ChayimFriedman2
Copy link
Contributor

The new version gives an additional salsa::Id to cycle handlers, and renames non_update_return_type to non_update_types.

Doing it separately to shrink my eventual GC PR, which is already huge.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 16, 2025
@ShoyuVanilla
Copy link
Member

ShoyuVanilla commented Dec 17, 2025

Failed test seems flaky 🤔 I'll re-run it

EDIT) Oh, I misread the message

[>240.000s] rust-analyzer::slow-tests ratoml::ratoml_root_is_updateable
       ABORT [ 241.146s] rust-analyzer::slow-tests ratoml::ratoml_root_is_updateable
           - with code 0xc0000409: The system detected an overrun of a stack-based buffer in this application. This overrun could potentially allow a malicious user to gain control of this application. (os error 1282)

@ChayimFriedman2
Copy link
Contributor Author

@ShoyuVanilla Failed test is not flaky, new Salsa has a deadlock, see salsa-rs/salsa#1039.

@ShoyuVanilla
Copy link
Member

Yeah, I misread the log 😅

The new version gives an additional `salsa::Id` to cycle handlers, and renames `non_update_return_type` to `non_update_types`.
@ChayimFriedman2 ChayimFriedman2 added this pull request to the merge queue Dec 17, 2025
Merged via the queue into rust-lang:master with commit 34fd9f6 Dec 17, 2025
15 checks passed
@ChayimFriedman2 ChayimFriedman2 deleted the upgrade-salsa branch December 17, 2025 11:19
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants